// SPDX-License-Identifier: GPL-2.0 AND MIT
/*
 * Copyright © 2026 Intel Corporation
 */

#include <kunit/test.h>
#include <kunit/test-bug.h>

#define TEST_KEY	(GUC_KLV_RESERVED_RANGE_START + 0x3de)
#define TEST_GROUP_KEY	(GUC_KLV_RESERVED_RANGE_START + 0x3f0)
#define TEST_PAD	0xdeadbeef

static bool fake_is_group_key(u16 key)
{
	return is_reserved_key(key) && key >= TEST_GROUP_KEY;
}

static void test_count(struct kunit *test)
{
	u32 value = 0x12345678;
	u16 key = TEST_KEY;
	u32 klvs[] = {
		PREP_GUC_KLV(key + 0, 0),
		PREP_GUC_KLV(key + 1, 1), value,
		PREP_GUC_KLV(key + 2, 2), value, value,
		PREP_GUC_KLV(key + 3, 0),
		0, /* padding */
	};

	KUNIT_EXPECT_EQ(test, 0, xe_guc_klv_count(klvs, 0));
	KUNIT_EXPECT_EQ(test, 1, xe_guc_klv_count(klvs, 1));
	KUNIT_EXPECT_GT(test, 0, xe_guc_klv_count(klvs, 2));
	KUNIT_EXPECT_EQ(test, 2, xe_guc_klv_count(klvs, 3));
	KUNIT_EXPECT_GT(test, 0, xe_guc_klv_count(klvs, 4));
	KUNIT_EXPECT_GT(test, 0, xe_guc_klv_count(klvs, 5));
	KUNIT_EXPECT_EQ(test, 3, xe_guc_klv_count(klvs, 6));
	KUNIT_EXPECT_EQ(test, 4, xe_guc_klv_count(klvs, 7));

	/* 0 is treated as reserved KLV { KEY=0, LEN=0 } */
	KUNIT_EXPECT_EQ(test, 5, xe_guc_klv_count(klvs, 8));
}

static void test_encode_u32(struct kunit *test)
{
	u32 *fail = ERR_PTR(-ENOMEM);
	u32 value = 0x12345678;
	u16 key = TEST_KEY;
	u32 klvs[16];

	memset32(klvs, TEST_PAD, ARRAY_SIZE(klvs));

	KUNIT_EXPECT_PTR_EQ(test, ERR_PTR(-ENOSPC), xe_guc_klv_encode_u32(klvs, 0, key, value));
	KUNIT_EXPECT_PTR_EQ(test, ERR_PTR(-ENOSPC), xe_guc_klv_encode_u32(klvs, 1, key, value));

	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, xe_guc_klv_encode_u32(klvs, 2, key, value));
	KUNIT_EXPECT_EQ(test, klvs[0], PREP_GUC_KLV(key, 1));
	KUNIT_EXPECT_EQ(test, klvs[1], value);
	KUNIT_EXPECT_EQ(test, klvs[2], TEST_PAD);
	KUNIT_EXPECT_PTR_EQ(test, &klvs[2], xe_guc_klv_encode_u32(klvs, 2, key, value));
	KUNIT_EXPECT_PTR_EQ(test,
			    xe_guc_klv_encode_u32(klvs, 2, key, value),
			    xe_guc_klv_encode_u32(klvs, ARRAY_SIZE(klvs), key, value));

	KUNIT_ASSERT_PTR_EQ(test, fail, xe_guc_klv_encode_u32(fail, ARRAY_SIZE(klvs), key, value));
}

static void test_encode_u64(struct kunit *test)
{
	u64 value = 0x123456789abcdef0;
	u32 *fail = ERR_PTR(-ENOMEM);
	u16 key = TEST_KEY;
	u32 klvs[16];

	memset32(klvs, TEST_PAD, ARRAY_SIZE(klvs));

	KUNIT_EXPECT_PTR_EQ(test, ERR_PTR(-ENOSPC), xe_guc_klv_encode_u64(klvs, 0, key, value));
	KUNIT_EXPECT_PTR_EQ(test, ERR_PTR(-ENOSPC), xe_guc_klv_encode_u64(klvs, 1, key, value));
	KUNIT_EXPECT_PTR_EQ(test, ERR_PTR(-ENOSPC), xe_guc_klv_encode_u64(klvs, 2, key, value));

	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, xe_guc_klv_encode_u64(klvs, 3, key, value));
	KUNIT_EXPECT_EQ(test, klvs[0], PREP_GUC_KLV(key, 2));
	KUNIT_EXPECT_EQ(test, klvs[1], lower_32_bits(value));
	KUNIT_EXPECT_EQ(test, klvs[2], upper_32_bits(value));
	KUNIT_EXPECT_EQ(test, klvs[3], TEST_PAD);
	KUNIT_EXPECT_PTR_EQ(test, &klvs[3], xe_guc_klv_encode_u64(klvs, 3, key, value));
	KUNIT_EXPECT_PTR_EQ(test,
			    xe_guc_klv_encode_u64(klvs, 3, key, value),
			    xe_guc_klv_encode_u64(klvs, ARRAY_SIZE(klvs), key, value));

	KUNIT_ASSERT_PTR_EQ(test, fail, xe_guc_klv_encode_u64(fail, ARRAY_SIZE(klvs), key, value));
}

static u32 str_klv_size(const char *string)
{
	return GUC_KLV_LEN_MIN + to_num_dwords(strlen(string) + 1);
}

static void test_encode_string(struct kunit *test)
{
	size_t longest_str = to_num_bytes(FIELD_MAX(GUC_KLV_0_LEN)) - 1;
	u32 avail = GUC_KLV_LEN_MIN + FIELD_MAX(GUC_KLV_0_LEN) + 1;
	const char *string = "abcdefghijklmnopqrstvwxyz";
	u16 key = TEST_KEY;
	u32 *klvs;
	u32 *next;
	char *buf;
	u32 n;

	klvs = kunit_kcalloc(test, avail, sizeof(u32), GFP_KERNEL);
	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, klvs);

	buf = kunit_kzalloc(test, longest_str + 2, GFP_KERNEL);
	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buf);

	/* empty string, no space, must fail */
	for (n = 0; n < str_klv_size(""); n++) {
		klvs[0] = TEST_PAD;
		KUNIT_EXPECT_PTR_EQ(test, ERR_PTR(-ENOSPC),
				    xe_guc_klv_encode_string(klvs, n, key, ""));
		KUNIT_EXPECT_EQ(test, klvs[0], TEST_PAD);
	}

	/* empty string, must pass */
	KUNIT_EXPECT_PTR_EQ(test, klvs + str_klv_size(""),
			    xe_guc_klv_encode_string(klvs, str_klv_size(""), key, ""));
	KUNIT_EXPECT_PTR_EQ(test, klvs + str_klv_size(""),
			    xe_guc_klv_encode_string(klvs, avail, key, ""));

	/* demo string, no space, must fail */
	for (n = 0; n < str_klv_size(string); n++) {
		klvs[0] = TEST_PAD;
		KUNIT_EXPECT_PTR_EQ(test, ERR_PTR(-ENOSPC),
				    xe_guc_klv_encode_string(klvs, n, key, string));
		KUNIT_EXPECT_EQ(test, klvs[0], TEST_PAD);
	}

	/* different string len, must pass */
	for (n = 0; n <= strlen(string); n++) {
		strscpy(buf, string, n + 1);
		kunit_info(test, "%u: '%s'\n", n, buf);
		KUNIT_ASSERT_EQ(test, n, strlen(buf));
		memset32(klvs, TEST_PAD, avail);

		next = xe_guc_klv_encode_string(klvs, str_klv_size(buf), key, buf);
		KUNIT_ASSERT_NOT_ERR_OR_NULL(test, next);
		KUNIT_EXPECT_PTR_EQ(test, next, klvs + str_klv_size(buf));
		KUNIT_EXPECT_STREQ_MSG(test, buf, (char *)(klvs + GUC_KLV_LEN_MIN), "n=%u", n);
		kunit_info(test, "%u: %*ph\n", n, (int)to_num_bytes(next - klvs), klvs);
		KUNIT_EXPECT_NE(test, *(next - 1), TEST_PAD);
		KUNIT_ASSERT_EQ(test, *next, TEST_PAD);

		/* bigger buf doesn't matter */
		KUNIT_EXPECT_PTR_EQ(test,
				    xe_guc_klv_encode_string(klvs, str_klv_size(buf), key, buf),
				    xe_guc_klv_encode_string(klvs, avail, key, buf));
	}

	/* don't crash if already failed */
	KUNIT_EXPECT_PTR_EQ(test, ERR_PTR(-EROFS),
			    xe_guc_klv_encode_string(ERR_PTR(-EROFS), avail, key, ""));

	/* too long string, must fail */
	memset(buf, 'X', longest_str + 1);
	buf[longest_str + 1] = '\0';
	KUNIT_EXPECT_LT(test, longest_str, strlen(buf));
	KUNIT_EXPECT_PTR_EQ(test, ERR_PTR(-E2BIG),
			    xe_guc_klv_encode_string(klvs, avail, key, buf));

	/* longest string, should pass */
	buf[longest_str] = '\0';
	KUNIT_EXPECT_EQ(test, longest_str, strlen(buf));
	KUNIT_EXPECT_PTR_EQ(test, klvs + str_klv_size(buf),
			    xe_guc_klv_encode_string(klvs, avail, key, buf));
}

struct some_object {
	u32 value1;
	u64 value2;
} __packed;

static u32 *obj_raw_encoder(u32 *klvs, u32 avail, const void *arg)
{
	const struct some_object *obj = arg;
	size_t sz = sizeof(*obj);
	u32 dwords = to_num_dwords(sz);

	if (IS_ERR(klvs))
		return klvs;
	if (dwords > avail)
		return ERR_PTR(-ENOSPC);
	memcpy(klvs, obj, sz);
	return klvs + dwords;
}

static u32 *obj_klv_encoder(u32 *klvs, u32 avail, const void *arg)
{
	const struct some_object *obj = arg;
	u32 *end = klvs + avail;

	klvs = xe_guc_klv_encode_u32(klvs, end - klvs, TEST_KEY + 1, obj->value1);
	klvs = xe_guc_klv_encode_u64(klvs, end - klvs, TEST_KEY + 2, obj->value2);
	return klvs;
}

static u32 *obj_nested_encoder(u32 *klvs, u32 avail, const void *arg)
{
	u32 *end = klvs + avail;

	klvs = xe_guc_klv_encode_object(klvs, end - klvs, TEST_GROUP_KEY + 1,
					arg, obj_klv_encoder);
	klvs = xe_guc_klv_encode_object(klvs, end - klvs, TEST_GROUP_KEY + 2,
					arg, obj_klv_encoder);
	return klvs;
}

static void test_encode_object_raw(struct kunit *test)
{
	const struct some_object obj = {
		.value1 = 0xdead1234,
		.value2 = 0xdead87654321dead,
	};
	u32 payload = to_num_dwords(sizeof(obj));
	u32 *err = ERR_PTR(-ENOSPC);
	u16 key = TEST_KEY;
	u32 klvs[16];
	u32 n;

	/* too small, must fail */
	for (n = 0; n < GUC_KLV_LEN_MIN + payload; n++) {
		memset32(klvs, TEST_PAD, ARRAY_SIZE(klvs));
		KUNIT_EXPECT_PTR_EQ_MSG(test, ERR_PTR(-ENOSPC),
					xe_guc_klv_encode_object(klvs, n, key, &obj,
								 obj_raw_encoder),
					"buf size=%u dwords", n);
	}

	/* must pass */
	memset32(klvs, TEST_PAD, ARRAY_SIZE(klvs));
	KUNIT_ASSERT_NOT_ERR_OR_NULL(test,
				     xe_guc_klv_encode_object(klvs, GUC_KLV_LEN_MIN + payload,
							      key, &obj, obj_raw_encoder));
	KUNIT_EXPECT_EQ(test, klvs[0], PREP_GUC_KLV(key, payload));
	KUNIT_EXPECT_MEMEQ(test, &klvs[1], &obj, sizeof(obj));

	/* already failed, must fail */
	KUNIT_ASSERT_PTR_EQ(test, err,
			    xe_guc_klv_encode_object(err, ARRAY_SIZE(klvs), key,
						     &obj, obj_raw_encoder));
}

static void test_encode_object_klv(struct kunit *test)
{
	const struct some_object obj = {
		.value1 = 0xdead1234,
		.value2 = 0xdead87654321dead,
	};
	u16 key = TEST_GROUP_KEY;
	u32 payload = 0;
	u32 klvs[16];
	u32 n;

	payload += GUC_KLV_LEN_MIN + to_num_dwords(sizeof(obj.value1));
	payload += GUC_KLV_LEN_MIN + to_num_dwords(sizeof(obj.value2));

	/* too small, must fail */
	for (n = 0; n < GUC_KLV_LEN_MIN + payload; n++) {
		memset32(klvs, TEST_PAD, ARRAY_SIZE(klvs));
		KUNIT_EXPECT_PTR_EQ_MSG(test, ERR_PTR(-ENOSPC),
					xe_guc_klv_encode_object(klvs, n, key, &obj,
								 obj_klv_encoder),
					"buf size=%u dwords", n);
	}

	/* must pass */
	memset32(klvs, TEST_PAD, ARRAY_SIZE(klvs));
	KUNIT_ASSERT_NOT_ERR_OR_NULL(test,
				     xe_guc_klv_encode_object(klvs, GUC_KLV_LEN_MIN + payload,
							      key, &obj, obj_klv_encoder));
	KUNIT_EXPECT_EQ(test, klvs[0], PREP_GUC_KLV(key, payload));
	KUNIT_EXPECT_EQ(test, klvs[1], PREP_GUC_KLV(TEST_KEY + 1, 1));
	KUNIT_EXPECT_EQ(test, klvs[2], obj.value1);
	KUNIT_EXPECT_EQ(test, klvs[3], PREP_GUC_KLV(TEST_KEY + 2, 2));
	KUNIT_EXPECT_EQ(test, klvs[4], lower_32_bits(obj.value2));
	KUNIT_EXPECT_EQ(test, klvs[5], upper_32_bits(obj.value2));
	KUNIT_EXPECT_EQ(test, klvs[6], TEST_PAD);
}

static void test_encode_object_nested(struct kunit *test)
{
	const struct some_object obj = {
		.value1 = 0xdead1234,
		.value2 = 0xdead87654321dead,
	};
	u16 key = TEST_GROUP_KEY;
	u32 payload = 0;
	u32 klvs[16];
	u32 n;

	payload += GUC_KLV_LEN_MIN;
	payload += GUC_KLV_LEN_MIN + to_num_dwords(sizeof(obj.value1));
	payload += GUC_KLV_LEN_MIN + to_num_dwords(sizeof(obj.value2));
	payload *= 2;

	/* too small, must fail */
	for (n = 0; n < GUC_KLV_LEN_MIN + payload; n++) {
		memset32(klvs, TEST_PAD, ARRAY_SIZE(klvs));
		KUNIT_EXPECT_PTR_EQ_MSG(test, ERR_PTR(-ENOSPC),
					xe_guc_klv_encode_object(klvs, n, key, &obj,
								 obj_nested_encoder),
					"buf size=%u dwords", n);
	}

	/* must pass */
	memset32(klvs, TEST_PAD, ARRAY_SIZE(klvs));
	KUNIT_ASSERT_NOT_ERR_OR_NULL(test,
				     xe_guc_klv_encode_object(klvs, GUC_KLV_LEN_MIN + payload,
							      key, &obj, obj_nested_encoder));
	KUNIT_EXPECT_EQ(test, klvs[0], PREP_GUC_KLV(key, payload));
	KUNIT_EXPECT_EQ(test, klvs[1], PREP_GUC_KLV(TEST_GROUP_KEY + 1, 5));
	KUNIT_EXPECT_EQ(test, klvs[2], PREP_GUC_KLV(TEST_KEY + 1, 1));
	KUNIT_EXPECT_EQ(test, klvs[3], obj.value1);
	KUNIT_EXPECT_EQ(test, klvs[4], PREP_GUC_KLV(TEST_KEY + 2, 2));
	KUNIT_EXPECT_EQ(test, klvs[5], lower_32_bits(obj.value2));
	KUNIT_EXPECT_EQ(test, klvs[6], upper_32_bits(obj.value2));
	KUNIT_EXPECT_EQ(test, klvs[7], PREP_GUC_KLV(TEST_GROUP_KEY + 2, 5));
	KUNIT_EXPECT_EQ(test, klvs[8], PREP_GUC_KLV(TEST_KEY + 1, 1));
	KUNIT_EXPECT_EQ(test, klvs[9], obj.value1);
	KUNIT_EXPECT_EQ(test, klvs[10], PREP_GUC_KLV(TEST_KEY + 2, 2));
	KUNIT_EXPECT_EQ(test, klvs[11], lower_32_bits(obj.value2));
	KUNIT_EXPECT_EQ(test, klvs[12], upper_32_bits(obj.value2));
	KUNIT_EXPECT_EQ(test, klvs[13], TEST_PAD);
}

static u32 *obj_echo_encoder(u32 *klvs, u32 avail, const void *arg)
{
	return ERR_CAST(arg);
}

static void test_encode_object_basic(struct kunit *test)
{
	u32 longest = GUC_KLV_LEN_MIN + FIELD_MAX(GUC_KLV_0_LEN);
	u32 avail = GUC_KLV_LEN_MIN + longest;
	u16 key = TEST_GROUP_KEY;
	u32 *klvs;

	klvs = kunit_kcalloc(test, avail, sizeof(u32), GFP_KERNEL);
	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, klvs);

	/* smallest */
	KUNIT_EXPECT_PTR_EQ(test, klvs + GUC_KLV_LEN_MIN,
			    xe_guc_klv_encode_object(klvs, avail, key,
						     klvs + GUC_KLV_LEN_MIN,
						     obj_echo_encoder));
	/* largest */
	KUNIT_EXPECT_PTR_EQ(test, klvs + longest,
			    xe_guc_klv_encode_object(klvs, avail, key,
						     klvs + longest,
						     obj_echo_encoder));
	/* already failed */
	KUNIT_EXPECT_PTR_EQ(test, ERR_PTR(-EROFS),
			    xe_guc_klv_encode_object(ERR_PTR(-EROFS), avail, key,
						     klvs + GUC_KLV_LEN_MIN,
						     obj_echo_encoder));
	/* encoding error */
	KUNIT_EXPECT_PTR_EQ(test, ERR_PTR(-EUCLEAN),
			    xe_guc_klv_encode_object(klvs, avail, key,
						     ERR_PTR(-EUCLEAN),
						     obj_echo_encoder));
	/* no space */
	KUNIT_EXPECT_PTR_EQ(test, ERR_PTR(-ENOSPC),
			    xe_guc_klv_encode_object(klvs, 0, key,
						     klvs + GUC_KLV_LEN_MIN,
						     obj_echo_encoder));
}

static const struct {
	u32 klvs[4];
	int expected_err;
	u16 expected_val;
	const char *name;
} decode_u16_params[] = {
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 0), ~0 },
		.expected_err = -ENODATA,
		.expected_val = 0xdead,
		.name = "empty",
	},
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 1), 1, ~0 },
		.expected_err = 0,
		.expected_val = 1,
		.name = "valid",
	},
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 1), U16_MAX, ~0 },
		.expected_err = 0,
		.expected_val = U16_MAX,
		.name = "max",
	},
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 1), U16_MAX + 1, ~0 },
		.expected_err = -EOVERFLOW,
		.expected_val = 0xdead,
		.name = "big",
	},
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 2), 1, 2, ~0 },
		.expected_err = -ENOMSG,
		.expected_val = 0xdead,
		.name = "long",
	},
};

KUNIT_ARRAY_PARAM_DESC(decode_u16, decode_u16_params, name);

static void test_decode_u16(struct kunit *test)
{
	typeof(decode_u16_params[0]) *param = test->param_value;
	const u32 *klvs = param->klvs;
	const u32 *value = klvs + GUC_KLV_LEN_MIN;
	u16 len = FIELD_GET(GUC_KLV_0_LEN, klvs[0]);
	u16 data = 0xdead;

	KUNIT_ASSERT_EQ(test, param->expected_err, xe_guc_klv_decode_u16(value, len, &data));
	KUNIT_ASSERT_EQ(test, param->expected_val, data);
}

static const struct {
	u32 klvs[4];
	int expected_err;
	u32 expected_val;
	const char *name;
} decode_u32_params[] = {
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 0), ~0 },
		.expected_err = -ENODATA,
		.expected_val = 0xdead,
		.name = "empty",
	},
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 1), 1, ~0 },
		.expected_err = 0,
		.expected_val = 1,
		.name = "valid",
	},
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 1), U32_MAX, ~0 },
		.expected_err = 0,
		.expected_val = U32_MAX,
		.name = "max",
	},
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 2), 1, 2, ~0 },
		.expected_err = -ENOMSG,
		.expected_val = 0xdead,
		.name = "long",
	},
};

KUNIT_ARRAY_PARAM_DESC(decode_u32, decode_u32_params, name);

static void test_decode_u32(struct kunit *test)
{
	typeof(decode_u32_params[0]) *param = test->param_value;
	const u32 *klvs = param->klvs;
	const u32 *value = klvs + GUC_KLV_LEN_MIN;
	u16 len = FIELD_GET(GUC_KLV_0_LEN, klvs[0]);
	u32 data = 0xdead;

	KUNIT_ASSERT_EQ(test, param->expected_err, xe_guc_klv_decode_u32(value, len, &data));
	KUNIT_ASSERT_EQ(test, param->expected_val, data);
}

static const struct {
	u32 klvs[4];
	int expected_err;
	u64 expected_val;
	const char *name;
} decode_u64_params[] = {
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 0), ~0 },
		.expected_err = -ENODATA,
		.expected_val = 0xdead,
		.name = "empty",
	},
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 1), 1, ~0, },
		.expected_err = -ENODATA,
		.expected_val = 0xdead,
		.name = "short",
	},
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 2), 1, 2, ~0 },
		.expected_err = 0,
		.expected_val = 0x200000001,
		.name = "valid",
	},
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 2), U32_MAX, U32_MAX, 3 },
		.expected_err = 0,
		.expected_val = U64_MAX,
		.name = "max",
	},
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 3), 1, 2, 3, },
		.expected_err = -ENOMSG,
		.expected_val = 0xdead,
		.name = "long",
	},
};

KUNIT_ARRAY_PARAM_DESC(decode_u64, decode_u64_params, name);

static void test_decode_u64(struct kunit *test)
{
	typeof(decode_u64_params[0]) *param = test->param_value;
	const u32 *klvs = param->klvs;
	const u32 *value = klvs + GUC_KLV_LEN_MIN;
	u16 len = FIELD_GET(GUC_KLV_0_LEN, klvs[0]);
	u64 data = 0xdead;

	KUNIT_ASSERT_EQ(test, param->expected_err, xe_guc_klv_decode_u64(value, len, &data));
	KUNIT_ASSERT_EQ(test, param->expected_val, data);
}

#define make_u32(a, b, c, d) \
	(FIELD_PREP_CONST(GENMASK_U32(31, 24), (a)) | \
	 FIELD_PREP_CONST(GENMASK_U32(23, 16), (b)) | \
	 FIELD_PREP_CONST(GENMASK_U32(15, 8), (c)) | \
	 FIELD_PREP_CONST(GENMASK_U32(7, 0), (d)))

static const struct {
	u32 klvs[4];
	int expected_err;
	const char *expected_str;
	const char *name;
} decode_str_params[] = {
	{
		.klvs = { PREP_GUC_KLV_CONST(TEST_KEY, 0), 'a', ~0 },
		.expected_err = -ENOMSG,
		.expected_str = NULL,
		.name = "empty",
	},
	{
		.klvs = {
				PREP_GUC_KLV_CONST(TEST_KEY, 1),
				make_u32(0, 0, 0, '1'),
			},
		.expected_err = 0,
		.expected_str = "1",
		.name = "one",
	},
	{
		.klvs = {
				PREP_GUC_KLV_CONST(TEST_KEY, 1),
				make_u32('3', '2', 0, '1'),
				'4', ~0
			},
		.expected_err = 0,
		.expected_str = "1",
		.name = "one_trash",
	},
	{
		.klvs = {
				PREP_GUC_KLV_CONST(TEST_KEY, 1),
				make_u32(0, 0, '2', '1'),
				'3', ~0
			},
		.expected_err = 0,
		.expected_str = "12",
		.name = "two",
	},
	{
		.klvs = {
				PREP_GUC_KLV_CONST(TEST_KEY, 1),
				make_u32('3', 0, '2', '1'),
				'4', ~0
			},
		.expected_err = 0,
		.expected_str = "12",
		.name = "two_trash",
	},
	{
		.klvs = {
				PREP_GUC_KLV_CONST(TEST_KEY, 1),
				make_u32(0, '3', '2', '1'),
				'4', ~0
			},
		.expected_err = 0,
		.expected_str = "123",
		.name = "three",
	},
	{
		.klvs = {
				PREP_GUC_KLV_CONST(TEST_KEY, 1),
				make_u32('4', '3', '2', '1'),
				'5', ~0
			},
		.expected_err = 0,
		.expected_str = "1234",
		.name = "dword",
	},
	{
		.klvs = {
				PREP_GUC_KLV_CONST(TEST_KEY, 2),
				make_u32('4', '3', '2', '1'),
				0, ~0
			},
		.expected_err = 0,
		.expected_str = "1234",
		.name = "four",
	},
	{
		.klvs = {
				PREP_GUC_KLV_CONST(TEST_KEY, 2),
				make_u32('4', '3', '2', '1'),
				make_u32(0, 0, 0, '5'),
				~0,
			},
		.expected_err = 0,
		.expected_str = "12345",
		.name = "five",
	},
	{
		.klvs = {
				PREP_GUC_KLV_CONST(TEST_KEY, 2),
				make_u32('4', '3', '2', '1'),
				make_u32(0, 0, '6', '5'),
				~0,
			},
		.expected_err = 0,
		.expected_str = "123456",
		.name = "six",
	},
	{
		.klvs = {
				PREP_GUC_KLV_CONST(TEST_KEY, 2),
				make_u32('4', '3', '2', '1'),
				make_u32(0, '7', '6', '5'),
				~0,
			},
		.expected_err = 0,
		.expected_str = "1234567",
		.name = "seven",
	},
	{
		.klvs = {
				PREP_GUC_KLV_CONST(TEST_KEY, 2),
				make_u32('4', '3', '2', '1'),
				make_u32('8', '7', '6', '5'),
				~0,
			},
		.expected_err = 0,
		.expected_str = "12345678",
		.name = "qword",
	},
};

KUNIT_ARRAY_PARAM_DESC(decode_str, decode_str_params, name);

static void test_decode_str(struct kunit *test)
{
	typeof(decode_str_params[0]) *param = test->param_value;
	const u32 *klvs = param->klvs;
	const u32 *value = klvs + GUC_KLV_LEN_MIN;
	u16 len = FIELD_GET(GUC_KLV_0_LEN, klvs[0]);
	char *data = NULL;

	KUNIT_EXPECT_EQ(test, param->expected_err, xe_guc_klv_decode_string(value, len, &data));
	if (!param->expected_err)
		KUNIT_EXPECT_STREQ(test, param->expected_str, data);
	kfree(data);
}

static void __drm_printfn_kunit(struct drm_printer *p, struct va_format *vaf)
{
	struct kunit *test = p->arg;

	kunit_info(test, "%pV", vaf);
}

static struct drm_printer drm_kunit_printer(void)
{
	struct drm_printer p = {
		.printfn = __drm_printfn_kunit,
		.arg = kunit_get_current_test(),
	};
	return p;
}

static void test_print(struct kunit *test)
{
	struct drm_printer p = drm_kunit_printer();
	u32 zeros[] = { 0, 0, 0, /* padding */ };
	u32 klvs[] = {
		PREP_GUC_KLV(GUC_KLV_OPT_IN_FEATURE_EXT_CAT_ERR_TYPE_KEY, 0),
		PREP_GUC_KLV(GUC_KLV_VF_CFG_NUM_CONTEXTS_KEY, 1), 1234,
		PREP_GUC_KLV(GUC_KLV_VF_CFG_GGTT_SIZE_KEY, 2), 0x4000, 0x0123,
		PREP_GUC_KLV(TEST_KEY, 3), 1, 2, 3,
		PREP_GUC_KLV(TEST_GROUP_KEY, 5),
		PREP_GUC_KLV(TEST_KEY + 1, 1), 1,
		PREP_GUC_KLV(TEST_KEY + 2, 2), 1, 2,
	};

	kunit_activate_static_stub(test, is_group_key, fake_is_group_key);
	xe_guc_klv_print(zeros, ARRAY_SIZE(zeros), &p);
	xe_guc_klv_print(klvs, ARRAY_SIZE(klvs), &p);
}

static struct kunit_case guc_klv_helpers_test_cases[] = {
	KUNIT_CASE(test_count),
	KUNIT_CASE(test_encode_u32),
	KUNIT_CASE(test_encode_u64),
	KUNIT_CASE(test_encode_string),
	KUNIT_CASE(test_encode_object_raw),
	KUNIT_CASE(test_encode_object_klv),
	KUNIT_CASE(test_encode_object_nested),
	KUNIT_CASE(test_encode_object_basic),
	KUNIT_CASE_PARAM(test_decode_u16, decode_u16_gen_params),
	KUNIT_CASE_PARAM(test_decode_u32, decode_u32_gen_params),
	KUNIT_CASE_PARAM(test_decode_u64, decode_u64_gen_params),
	KUNIT_CASE_PARAM(test_decode_str, decode_str_gen_params),
	KUNIT_CASE(test_print),
	{}
};

static struct kunit_suite guc_klv_helpers_suite = {
	.name = "guc_klv_helpers",
	.test_cases = guc_klv_helpers_test_cases,
};

kunit_test_suite(guc_klv_helpers_suite);